zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1951145929
##########
datafusion/sqllogictest/test_files/aggregate_skip_partial.slt:
##########
@@ -228,7 +228,7 @@ CREATE TABLE aggregate_test_100_null (
c11 FLOAT
);
-statement ok
+statement error DataFusion error: Error during planning: Inserting query must
have the same schema nullability as the table\. Expected table field 'c5'
nullability: false, got field: 'c5', nullability: true
Review Comment:
This is the only regression in the slt i think. cc @jayzhan211 @jonahgao
```rust
# Setup test data table
statement ok
CREATE EXTERNAL TABLE aggregate_test_100 (
c1 VARCHAR NOT NULL,
c2 TINYINT NOT NULL,
c3 SMALLINT NOT NULL,
c4 SMALLINT,
c5 INT,
c6 BIGINT NOT NULL,
c7 SMALLINT NOT NULL,
c8 INT NOT NULL,
c9 INT UNSIGNED NOT NULL,
c10 BIGINT UNSIGNED NOT NULL,
c11 FLOAT NOT NULL,
c12 DOUBLE NOT NULL,
c13 VARCHAR NOT NULL
)
STORED AS CSV
LOCATION '../../testing/data/csv/aggregate_test_100.csv'
OPTIONS ('format.has_header' 'true');
statement ok
CREATE TABLE aggregate_test_100_null (
c2 TINYINT NOT NULL,
c5 INT NOT NULL,
c3 SMALLINT,
c11 FLOAT
);
statement error DataFusion error: Error during planning: Inserting query
must have the same schema nullability as the table\. Expected table field 'c5'
nullability: false, got field: 'c5', nullability: true
INSERT INTO aggregate_test_100_null
SELECT
c2,
c5,
CASE WHEN c1 = 'e' THEN NULL ELSE c3 END as c3,
CASE WHEN c1 = 'a' THEN NULL ELSE c11 END as c11
FROM aggregate_test_100;
```
I think the original behaviour is wrong, because the insert table is not
nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
