Rachelint commented on issue #14586: URL: https://github.com/apache/datafusion/issues/14586#issuecomment-2648625729
> > I am trying a poc about support block approach by only modifying codes of group values(we also need to modifying codes of GroupAccumulatortoo in [#11943](https://github.com/apache/datafusion/pull/11943)). > > If the performance gains are worth it I can potentially help organize a larger refactoring effort too (to incrementally port over the code). We are in much better shape test-wise now. If you have a good approach I'll find time to help coordinate I will find a query to measurement the performance in old implementation in #11943 and in the new implementation. I guess they will have the similar performance but I am still not sure now. And if approach about supporting this only by `GroupValues`, it may be easy to introduce another optimization #12526 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
