iffyio commented on code in PR #1713:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1713#discussion_r1947123514
##########
tests/sqlparser_duckdb.rs:
##########
@@ -246,6 +246,67 @@ fn test_create_table_macro() {
assert_eq!(expected, macro_);
}
+#[test]
+fn test_select_from_first() {
Review Comment:
@mitsuhiko could we move this test to
[sqlparser_common.rs](https://github.com/apache/datafusion-sqlparser-rs/blob/8026966ba12b6cb7f2ee9bfa92d80e48ff1650f7/tests/sqlparser_common.rs)
and use the `all_dialects_where(|d| d.supports_from_first_select())`? so that
it covers both duckdb and clickhouse (and any future dialects)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
