mertak-synnada commented on PR #14517: URL: https://github.com/apache/datafusion/pull/14517#issuecomment-2642242663
> this downcast introduced in https://github.com/apache/datafusion/pull/14224, probably needs to be moved/removed(for this issue), but I am not sure where/how, or can we make do without it(like before)? Sorry I'm pretty new to this issue's context, Is it a problem because of dependency? If so, with an ugly solution, we can check the `self.source.file_type() == "avro"` here. Or we may create, another level of abstraction and ask that API the file type. In the early implementation of #14224, `file_type()` was returning a `dyn FileType` trait but since it was only being used in `to_str` and these type checking we removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
