jkosh44 commented on PR #14532: URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2641969506
> See this, [#13819 (comment)](https://github.com/apache/datafusion/issues/13819#issuecomment-2552554818). We only convert an inner fixed-size list to a regular list when the function performs a mutation operation, such as `array_append`. For non-mutation operations, like `array_element`, we keep T as a fixed-size list Ah ok, so the idea was that if the function changed the size of the list, then it would recursively convert `FixedSizedList` to `List`, but if it didn't change the size then it would only change the top level `FixedSizedList` to a `List`. However, it looks like the code was making the assumption that all `ArrayAndIndexes` functions did not modify the list which was actually no longer true after https://github.com/apache/datafusion/commit/3dfce7d33c19d6e7941b58cb7e83194c066347ca. So it sounds like we need to include in the array signature whether or not the function might change the size of the list and use that information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
