himadripal commented on code in PR #1369:
URL: https://github.com/apache/datafusion-comet/pull/1369#discussion_r1945281504
##########
native/core/src/execution/jni_api.rs:
##########
@@ -285,11 +287,14 @@ fn parse_memory_pool_config(
memory_limit: i64,
memory_limit_per_task: i64,
) -> CometResult<MemoryPoolConfig> {
+ let pool_size = memory_limit as usize;
let memory_pool_config = if use_unified_memory_manager {
- MemoryPoolConfig::new(MemoryPoolType::Unified, 0)
+ match memory_pool_type.as_str() {
+ "unified" => MemoryPoolConfig::new(MemoryPoolType::Unified, 0),
+ _ => MemoryPoolConfig::new(MemoryPoolType::FairUnified, pool_size),
Review Comment:
as FairUnified is default, may be doc should reflect it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
