DanCodedThis commented on code in PR #1702:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1702#discussion_r1944408128
##########
src/dialect/snowflake.rs:
##########
@@ -182,6 +183,15 @@ impl Dialect for SnowflakeDialect {
return Some(parse_file_staging_command(kw, parser));
}
+ if parser.parse_keyword(Keyword::SHOW) {
+ let terse = parser.parse_keyword(Keyword::TERSE);
+ if parser.parse_keyword(Keyword::OBJECTS) {
+ return Some(parse_show_objects(terse, parser));
+ } else {
+ return Some(parser.parse_show());
Review Comment:
Originally there was no **else** branch, but there was a bug in my code,
which was fixed like this (maybe this is too _hacky_?). The bug wasn't found or
fixed by me. But for example, before the **else** branch: when we got
`DATABASES` instead of `OBJECTS` we got an error in other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
