mbrobbel commented on code in PR #14511:
URL: https://github.com/apache/datafusion/pull/14511#discussion_r1943055656
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -243,7 +251,7 @@ fn try_coerce_types(
// none possible -> Error
plan_err!(
"Failed to coerce arguments to satisfy a call to {} function: coercion
from {:?} to the signature {:?} failed.",
- function_name.as_ref(),
+ function_name,
Review Comment:
You can move this inside the `{}` -> `{function_name}` (I can't suggest
outside the diff)
And the others using `{current_types:?}` and `{type_signature:?}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
