zhuqi-lucas commented on code in PR #14499:
URL: https://github.com/apache/datafusion/pull/14499#discussion_r1942531772
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -472,6 +498,7 @@ impl Stream for ObservedStream {
cx: &mut Context<'_>,
) -> Poll<Option<Self::Item>> {
let poll = self.inner.poll_next_unpin(cx);
+ let poll = self.limit_reached(poll);
Review Comment:
Nit:
> let Some(fetch) = self.fetch else { return poll };
May be we can move the following to above, only call limit_reached when
```rust
let Some(fetch) = self.fetch {
poll = self.limit_reached(poll);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
