parthchandra commented on code in PR #1324:
URL: https://github.com/apache/datafusion-comet/pull/1324#discussion_r1939880331
##########
spark/src/main/scala/org/apache/comet/testing/ParquetGenerator.scala:
##########
@@ -58,6 +55,12 @@ object ParquetGenerator {
val dataTypes = ListBuffer[DataType]()
dataTypes.appendAll(primitiveTypes)
+ if (options.generateTimestamps) {
+ dataTypes += DataTypes.TimestampType
+ // TimestampNTZType only in Spark 3.4+
Review Comment:
Can we use `CometSparkSessionExtensions.isSpark3.4Plus` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
