duongcongtoai commented on code in PR #14395: URL: https://github.com/apache/datafusion/pull/14395#discussion_r1938392097
########## datafusion/core/tests/dataframe/mod.rs: ########## @@ -3325,6 +3326,74 @@ async fn unnest_columns() -> Result<()> { Ok(()) } +#[tokio::test] +async fn unnest_dict_encoded_columns() -> Result<()> { + let ctx = SessionContext::new(); + + let str1 = lit(ScalarValue::Dictionary( + Box::new(DataType::Int32), + Box::new(ScalarValue::new_utf8("x")), + )); + let str2 = lit(ScalarValue::Dictionary( + Box::new(DataType::Int32), + Box::new(ScalarValue::new_utf8("y")), + )); + + let make_array_udf_expr1 = Expr::ScalarFunction(ScalarFunction::new_udf( + make_array_udf(), + vec![col("column1")], + )); Review Comment: thanks, i applied the suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org