alamb commented on code in PR #14392:
URL: https://github.com/apache/datafusion/pull/14392#discussion_r1938062695
##########
Cargo.toml:
##########
@@ -32,6 +32,7 @@ members = [
"datafusion/functions-aggregate-common",
"datafusion/functions-table",
"datafusion/functions-nested",
+ "datafusion/functions-spark",
"datafusion/functions-window",
"datafusion/functions-window-common",
Review Comment:
🤔 you are right that it is kind of strange to have all spark functions in a
single crate when we have the other functions in more fine grained crates
Maybe we should make one crate like `datafusion_spark` that holds all the
different types of functions:
```suggestion
"datafusion/functions-table",
"datafusion/functions-nested",
"datafusion/spark",
"datafusion/functions-window",
"datafusion/functions-window-common",
````
And then over time we can add things like
`datafusion_spark_functions_nested` in `datafusion/spark/functions-nested` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
