remysaissy commented on PR #1687:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1687#issuecomment-2627274710

   @alamb, I don't see how the `parse_join_constraint_unnest_alias` (nightly 
build failure) is related to this commit since the difference is related to a 
Join becoming an Inner in the AST and the initial query is not a CREATE 
FUNCTION nor it uses the TABLE in it.
   
   Regarding the parse_trigger_related_functions, I think it is related to 
another PR: https://github.com/apache/datafusion-sqlparser-rs/pull/1690 since 
the `parse_create_function` from beta and nightly failed on a query related to 
Hive. 
   This has been fixed after my commit was merged but since the log stops at 
the first error so maybe there was other errors as well.
   
   I propose to fix these failures in another PR that I will mark related to 
the #1690 if that's ok for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to