alamb commented on code in PR #14361:
URL: https://github.com/apache/datafusion/pull/14361#discussion_r1936106746
##########
datafusion-cli/Cargo.toml:
##########
@@ -31,16 +31,11 @@ readme = "README.md"
[dependencies]
arrow = { version = "54.0.0" }
async-trait = "0.1.73"
-## 1.5.13 requires a hiher MSRV 1.81 so lock until DataFusion MSRV catches up
-aws-config = "=1.5.10"
-## 1.53.0 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
-aws-sdk-sso = "=1.50.0"
-## 1.54.0 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
-aws-sdk-ssooidc = "=1.57.1"
-## 1.54.1 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
-aws-sdk-sts = "=1.51.0"
-# end pin aws-sdk crates
-aws-credential-types = "1.2.0"
+aws-config = "1.5.15"
Review Comment:
> We probably can provide a minor version and let rustc take the latest
patch. However it is not very expected when the patch requires MSRV change
though.... WDYT folks if we set all deps without the specifc patch version and
see how it is going.
Sounds good to me -- I will do so
I think the practical implication of `1.5.15` is that it will also allow
anything higher, such as `1.6`, `1.5.16`
Since everything in datafusion-cli is controlled by `Cargo.lock` the
versions won't change without a change to that file anyways.
That being said there is no reason to have this patch version as you say so
I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
