kylebarron commented on issue #1008: URL: https://github.com/apache/datafusion-python/issues/1008#issuecomment-2624807853
> this is only a subset of what obstore allows Yes, `obstore` is a full binding to `object_store` and intends to allow the full configuration that you can do in Rust. > remember their construction arguments Well, that's adding complexity on the datafusion-python side... > query them from the built ObjectStore This isn't generally possible. Once you have an [`AmazonS3`](https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3.html) you can't backtrack to the builder parameters. If instead you store a [`AmazonS3Builder`](https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3Builder.html), then you can access **some but not all** config parameters (those whose values are representable by `String`) via [`get_config_value`](https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3Builder.html#method.get_config_value). But this also means that _every time you use the store_ you'd have to call `AmazonS3Builder.build`, which has overhead. > expose them in a way that lets us then construct the equivalent obstore version from python This sounds like replicating the configuration system that exists in Rust in pure Python, which sounds difficult to maintain. ---- I would love to see something like this exist, because it's also necessary for [pickling](https://github.com/developmentseed/obstore/issues/125), and would love to see a PR. But so far I'm skeptical of a solution that's maintainable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
