findepi commented on issue #14363: URL: https://github.com/apache/datafusion/issues/14363#issuecomment-2623901400
Join output schema is very difficult topic, especially when using USING. It might be there is no one size fits all answer, but _some_ (well defined) answer may be packaged as `try_new` (or differently named method), as long as it's not enforced as the only blessed way to construct `Join`. I see how `recompute_schema` may be useful in the case where it's a newly constructed Join and doesn't have good schema yet. Fixing schema at construction time would be better -- ie creating truth is better than creating falsehood and fixing it later. Especially that recompute_schema has its own problems (https://github.com/apache/datafusion/issues/14357). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
