ozankabak commented on code in PR #14271: URL: https://github.com/apache/datafusion/pull/14271#discussion_r1934352834
########## datafusion/expr/src/udaf.rs: ########## @@ -818,6 +826,26 @@ pub mod aggregate_doc_sections { }; } +/// Status of an Aggregate Expression's Set Monotonicity +#[derive(Debug, Clone)] +pub enum AggregateExprSetMonotonicity { + /// Ordering exists as ascending Review Comment: I think we should probably use the naming `AggregateExprSetMonotonicity::Increasing`, which would be self-documenting. I will make the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org