alamb commented on code in PR #14359:
URL: https://github.com/apache/datafusion/pull/14359#discussion_r1934030696
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -491,9 +497,7 @@ impl TestFile {
}
}
-fn read_test_files<'a>(
- options: &'a Options,
-) -> Result<Box<dyn Iterator<Item = TestFile> + 'a>> {
+fn read_test_files(options: &Options) -> Result<Vec<TestFile>> {
Review Comment:
This function was already basically returning a `Vec` so there didn't seem
to be any need to have the iterator indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
