eliaperantoni commented on PR #13664: URL: https://github.com/apache/datafusion/pull/13664#issuecomment-2620192416
> I also think before/part of merging this PR would be to document what is needed before we would want to turn on collect_spans by default In my opinion: - Putting `Span` on more logical types in order to.. - Attach `Diagnostic` to more errors, until most of the typical errors that we can expect the end user to make are covered I know it's a little vague but, as a starting point, I would consider: - Reference to a function that doesn't exist - Wrong number of parameters in a function call - Wrong types of parameters in a function call - Syntax errors - Subquery that returns more than one column - Type coercion in unary expressions - Using `= NULL` instead of `IS NULL`, maybe that could be the first use case of `Diagnostic::new_warning` - Alias two columns/tables with the same name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
