rluvaton commented on code in PR #14299:
URL: https://github.com/apache/datafusion/pull/14299#discussion_r1932880307
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -177,6 +177,67 @@ impl ArrayAggAccumulator {
datatype: datatype.clone(),
})
}
+
+ /// This function will return the underlying list array values if all
valid values are consecutive without gaps (i.e. no null value point to a non
empty list)
+ /// If there are gaps but only in the end of the list array, the function
will return the values without the null values in the end
+ fn get_optional_values_to_merge_as_is(list_array: &ListArray) ->
Option<ArrayRef> {
+ let offsets = list_array.value_offsets();
+ // Offsets always have at least 1 value
+ let initial_offset = offsets[0];
+ let null_count = list_array.null_count();
+
+ // If no nulls than just use the fast path
+ // This is ok as the state is a ListArray rather than a ListViewArray
so all the values are consecutive
+ if null_count == 0 {
+ // According to Arrow specification, the first offset can be
non-zero
Review Comment:
while writing this code I first found out that offsets does not have to
start from 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
