zhuqi-lucas commented on PR #14338: URL: https://github.com/apache/datafusion/pull/14338#issuecomment-2618998894
I am confident now, because i also checked the full outer join pushdown filter, we will not push down for full outer join for both side, code reference: ```rust // Get pushable predicates from current optimizer state let (left_preserved, right_preserved) = lr_is_preserved(join.join_type); ``` ```rust pub(crate) fn lr_is_preserved(join_type: JoinType) -> (bool, bool) { match join_type { JoinType::Inner => (true, true), JoinType::Left => (true, false), JoinType::Right => (false, true), JoinType::Full => (false, false), // No columns from the right side of the join can be referenced in output // predicates for semi/anti joins, so whether we specify t/f doesn't matter. JoinType::LeftSemi | JoinType::LeftAnti | JoinType::LeftMark => (true, false), // No columns from the left side of the join can be referenced in output // predicates for semi/anti joins, so whether we specify t/f doesn't matter. JoinType::RightSemi | JoinType::RightAnti => (false, true), } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org