shehabgamin commented on code in PR #14268: URL: https://github.com/apache/datafusion/pull/14268#discussion_r1929718209
########## datafusion/sqllogictest/test_files/expr.slt: ########## @@ -344,6 +344,16 @@ SELECT ascii('💯a') ---- 128175 +query I +SELECT ascii('222') +---- +50 + +query I +SELECT ascii(2) Review Comment: The behavior is consistent with Spark, the tests come from the Spark codebase as well. ``` spark-sql (default)> SELECT ASCII(2); 50 Time taken: 0.952 seconds, Fetched 1 row(s) spark-sql (default)> SELECT ASCII('2'); 50 Time taken: 0.044 seconds, Fetched 1 row(s) spark-sql (default)> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org