logan-keede commented on issue #13845: URL: https://github.com/apache/datafusion/issues/13845#issuecomment-2612302035
> Thank you for the good ideas [@logan-keede](https://github.com/logan-keede) > > Given we have > > 1. Very limited bandwidth for maintenance (and even less for infrastructure maintenance) > 2. Effectively unlimited github workers (thank you github for contirbution in kind!) > > I think we should priortize ease of maintenance / understability in the CI scripts > > While using pre-built docker images seems like it would indeed improve performance, we would have to be careful with how much extra complexity it woudl add to the build system maybe we can revisit it in the future when we have more bandwidth for maintenance, > GitHub cache is great, but 20GB cached state is pretty sizeable, so could imply quick invalidation. The cache isn't maintenance free. For example the build should handle the case where cache state is no longer there. hmm I am not sure but seems like this might require a lot of exploration and testing before we can use such approach, even if we have more workforce focusing on maintenance. > [@logan-keede](https://github.com/logan-keede) do you maybe know how to do test impact analysis with cargo? This is the first time I ever heard of this term, but now that I have looked into it has certainly piqued my interest, will read up on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
