andygrove commented on code in PR #1332:
URL: https://github.com/apache/datafusion-comet/pull/1332#discussion_r1927466775
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -3435,24 +3435,10 @@ fn builder_to_array(
}
fn make_batch(arrays: Vec<ArrayRef>, row_count: usize) -> Result<RecordBatch,
ArrowError> {
- let mut dict_id = 0;
let fields = arrays
.iter()
.enumerate()
- .map(|(i, array)| match array.data_type() {
- DataType::Dictionary(_, _) => {
- let field = Field::new_dict(
Review Comment:
another case where we can no longer re-use dictionary id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
