andygrove commented on code in PR #1331:
URL: https://github.com/apache/datafusion-comet/pull/1331#discussion_r1927433897
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -19,18 +19,23 @@
package org.apache.comet.serde
-import org.apache.spark.sql.catalyst.expressions.{ArrayRemove, Expression}
+import org.apache.spark.sql.catalyst.expressions.{ArrayRemove, Attribute,
Expression}
import org.apache.spark.sql.types.{ArrayType, DataType, DataTypes,
DecimalType, StructType}
import org.apache.comet.CometSparkSessionExtensions.withInfo
+import org.apache.comet.serde.QueryPlanSerde.createBinaryExpr
import org.apache.comet.shims.CometExprShim
-trait CometExpression {
- def checkSupport(expr: Expression): Boolean
+trait CometExpressionSerde {
Review Comment:
I moved the trait and added some scaladocs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
