Spaarsh commented on code in PR #14225:
URL: https://github.com/apache/datafusion/pull/14225#discussion_r1926476600
##########
benchmarks/bench.sh:
##########
@@ -536,23 +536,52 @@ data_imdb() {
done
if [ "$convert_needed" = true ]; then
- if [ ! -f "${imdb_dir}/imdb.tgz" ]; then
- echo "Downloading IMDB dataset..."
+ # Expected size of the dataset
Review Comment:
I have removed numfmt. It's purpose was to simply make the file size
readable (ie as 1.18 Gb rather than 12429181 or such).
If readability is a concern, I can write a function of my own that
simplifies the values.
If readability is not a concern, then this is good to go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
