parthchandra commented on PR #1318:
URL:
https://github.com/apache/datafusion-comet/pull/1318#issuecomment-2608586806
> spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
>
> ```
> Seq("parquet").foreach { v1List =>
> withSQLConf(
> SQLConf.USE_V1_SOURCE_LIST.key -> v1List,
> CometConf.COMET_ENABLED.key -> "true",
> CometConf.COMET_NATIVE_SCAN_IMPL.key ->
CometConf.SCAN_NATIVE_DATAFUSION,
> CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true") {
> ```
>
> Previously the test was testing v2 reader as well by `Seq("", "parquet").`
although the test was ignored.
native_datafusion does not implement v2 yet. But I suppose we can enable it
for the test and ensure it falls back to Spark correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
