parthchandra commented on PR #1320: URL: https://github.com/apache/datafusion-comet/pull/1320#issuecomment-2608471213
> @parthchandra E.g. for the utils file fromArrowType is defined in both files Oh, I get it now. We did duplicate code in the feature branch (CometArrowUtils and Utils both duplicate code from Spark. Let me clean this up in a followup) The cast.rs and parquet_support.rs duplication is intentional. We used the former as the starting point for parquet type conversions. The parquet_support code will change as we address more data types. > Another potential issue spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala](https://github.com/apache/datafusion-comet/blob/main/spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala#L349 is testing only when the mode is SCAN_NATIVE_COMET? Yes. The plans are different when the scans are different. We generated new plans for the different scan types but did not turn them on. The two new scan implementations do not yet pass all the unit tests so turning on plan stability for them is a little premature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
