vbarua commented on code in PR #14194:
URL: https://github.com/apache/datafusion/pull/14194#discussion_r1926013015
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1228,6 +1237,105 @@ async fn verify_post_join_filter_value(proto:
Box<Plan>) -> Result<()> {
Ok(())
}
+fn count_read_best_effort_filters(rel: &Rel, count: &mut u32) -> Result<()> {
Review Comment:
If we set the `filter` field instead of `best_effort_filter` I don't think
we need this anymore.
But if we were, I would suggest implementing this a SubstraitConsumer that
overrides the `consume_read_rel`
[method](https://github.com/apache/datafusion/blob/0ba6e70581ef25f1f85693923653727bc202bbe3/datafusion/substrait/src/logical_plan/consumer.rs#L245-L247)
to increment a counter for the number of best-effor filters seen,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
