kazuyukitanimura commented on PR #1318:
URL:
https://github.com/apache/datafusion-comet/pull/1318#issuecomment-2606140490
@andygrove @parthchandra
```
// data source V1
case scanExec @ FileSourceScanExec(
HadoopFsRelation(_, partitionSchema, _, _, fileFormat, _),
_: Seq[_],
requiredSchema,
_,
_,
_,
_,
_,
_)
if CometScanExec.isFileFormatSupported(fileFormat)
&& CometNativeScanExec.isSchemaSupported(requiredSchema)
&& CometNativeScanExec.isSchemaSupported(partitionSchema)
// TODO we only enable full native scan if
COMET_EXEC_ENABLED is enabled
// but this is not really what we want .. we currently
insert `CometScanExec`
// here and then it gets replaced with `CometNativeScanExec`
in `CometExecRule`
// but that only happens if `COMET_EXEC_ENABLED` is enabled
&& COMET_EXEC_ENABLED.get()
&& COMET_NATIVE_SCAN_IMPL.get() ==
CometConf.SCAN_NATIVE_DATAFUSION =>
logInfo("Comet extension enabled for v1 full native Scan")
CometScanExec(scanExec, session)
// data source V1
case scanExec @ FileSourceScanExec(
HadoopFsRelation(_, partitionSchema, _, _, fileFormat, _),
_: Seq[_],
requiredSchema,
_,
_,
_,
_,
_,
_)
if CometScanExec.isFileFormatSupported(fileFormat)
&& CometScanExec.isSchemaSupported(requiredSchema)
&& CometScanExec.isSchemaSupported(partitionSchema) =>
logInfo("Comet extension enabled for v1 Scan")
CometScanExec(scanExec, session)
```
This looks `CometScanExec` gets used regardless `COMET_EXEC_ENABLED` and
`COMET_NATIVE_SCAN_IMPL` checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
