comphead commented on PR #14160: URL: https://github.com/apache/datafusion/pull/14160#issuecomment-2600971996
Tbh, I was not able to find `BatchCoalescer` in joins, the closest was `CoalesceBatchesExec` in bunch of physical plan nodes including `sort_preserving_merge.rs` 🤔 But it will make the code cleaner for sure! Appreciate if you can point me how it is being used in the joins to have join code base consistent. WDYT to go forward with this PR to close the bug and I create another ticket to improve the codebase using `BatchCoalescer` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
