iffyio commented on code in PR #1655:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1655#discussion_r1919785022
##########
src/parser/mod.rs:
##########
@@ -8452,6 +8458,31 @@ impl<'a> Parser<'a> {
}
}
+ /// Parse a literal unicode normalization clause
+ pub fn parse_unicode_is_normalized(
+ &mut self,
+ ) -> Result<(Option<NormalizationForm>, bool), ParserError> {
Review Comment:
Oh the return type becomes a bit surprising by returning a bool, since this
is a public API would it make sense to have it return the expr instead
`Expr::IsNormalized` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
