peter-toth commented on PR #13618: URL: https://github.com/apache/datafusion/pull/13618#issuecomment-2597751904
Hi @alamb, sure we can close this PR. If I get the above comments right, there will be a new IR plan structure and the current optimizer rules will be rewritten to work on that. Once DataFusion reached that point we can revisit this PR to improve traversal speed of optimizer rules. However, the idea in this PR is not specific to optimizer rules. It can improve analyzer rules (I think we want to keep them using `LogicalPlan`s, do we?) and physical plan rules and actually any kinds of `TreeNode` trees as well. So I feel it is orthogonal to having a new IR plan structure... The problem with `LogicalPlan`/`Expr` is that it is defined as an enum, so it is not easy to add derived stats about the tree structure into the nodes without breaking compatibility... Maybe I should open a PR for `ExecutionPlan`/`PhysicalExpr`, where this is not an issue, first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
