jonahgao commented on code in PR #14145:
URL: https://github.com/apache/datafusion/pull/14145#discussion_r1917839619


##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -1112,6 +1113,14 @@ pub(crate) fn need_produce_result_in_final(join_type: 
JoinType) -> bool {
     )
 }
 
+pub fn get_final_indices_from_shared_bitmap(

Review Comment:
   Is `pub` necessary here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to