Curricane commented on PR #14133: URL: https://github.com/apache/datafusion/pull/14133#issuecomment-2594286581
> Hi @Curricane -- thank you for the fix 🙏 > > Can you please add some tests, ideally in sqllogicteset format to ensure this behavior is not broken in the future. > > Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest > > Ideally you should be able to extend one of the existing test files in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files > > Perhaps https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/ddl.slt Sure, but could we merge this PR first? I can create another PR to handle this task because I'm not very familiar with writing this kind of test and will need some time to work on it. I hope to use the version of DataFusion that fixes this issue as soon as possible since it's critical for my project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
