seve-martinez commented on PR #1566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566#issuecomment-2593395062
> I did not notice this PR when I started working on parsing the SAMPLE option, but since then it was merged: #1580 > > I can share that we used to parse the SAMPLE option as part of the TableFactor but it wasn't ideal, and moving it to the select made more sense. Oh awesome! Thanks for taking care of it, I wasn't in love with my solution and what you have there looks very sound. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
