Spaarsh commented on PR #14129: URL: https://github.com/apache/datafusion/pull/14129#issuecomment-2591568792
Even I was thinking the same! But I wanted to ensure first that the same directory isn't being used to store other files. Since I would be using the ```rm -rf``` command here, that data would've been removed too without any warning. There was also the concern of making it easier for subsequent developers to work on this. In case the ```imdb``` directory finds a new usecase, the function would have to be changed at that point. I also planned to make the cleanup function as a util function. So that it can be used wherever atomicity was needed in the ```bench.sh``` , hence I wanted to make it as general as possible. Would like your thoughts on this! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
