jonahgao commented on code in PR #14102:
URL: https://github.com/apache/datafusion/pull/14102#discussion_r1912765058
##########
datafusion/expr/src/utils.rs:
##########
@@ -705,27 +711,20 @@ pub fn exprlist_to_fields<'a>(
.map(|e| match e {
Expr::Wildcard { qualifier, options } => match qualifier {
Review Comment:
Another issue is that in
[exprlist_to_fields](https://github.com/apache/datafusion/blob/f9cc3325cdb5891b7566a6f3503c1f7ac6ad51e0/datafusion/expr/src/utils.rs#L696),
we don't handle replace items, but `ExpandWildcardRule` does.
`select * replace ('foo' as a) from t` will give the wrong datatype in
schema before executing analyzer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
