jayzhan211 commented on code in PR #14094:
URL: https://github.com/apache/datafusion/pull/14094#discussion_r1912405839
##########
datafusion/functions/src/core/arrow_cast.rs:
##########
@@ -86,22 +87,36 @@ impl ScalarUDFImpl for ArrowCastFunc {
}
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
Review Comment:
If this looks good, we can deprecate this too
##########
datafusion/functions/src/core/arrow_cast.rs:
##########
@@ -86,22 +87,36 @@ impl ScalarUDFImpl for ArrowCastFunc {
}
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
Review Comment:
If this change looks good, we can deprecate this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
