kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1908071116
##########
python/datafusion/dataframe.py:
##########
@@ -620,17 +679,34 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parquet(
self,
path: str | pathlib.Path,
- compression: str = "uncompressed",
+ compression: str = Compression.ZSTD.value,
compression_level: int | None = None,
) -> None:
"""Execute the :py:class:`DataFrame` and write the results to a
Parquet file.
Args:
path: Path of the Parquet file to write.
- compression: Compression type to use.
- compression_level: Compression level to use.
- """
- self.df.write_parquet(str(path), compression, compression_level)
+ compression: Compression type to use. Default is "ZSTD".
+ Available compression types are:
+ - "uncompressed": No compression.
+ - "snappy": Snappy compression.
+ - "gzip": Gzip compression.
+ - "brotli": Brotli compression.
+ - "lz0": LZ0 compression.
+ - "lz4": LZ4 compression.
+ - "lz4_raw": LZ4_RAW compression.
+ - "zstd": Zstandard compression.
+ compression_level: Compression level to use. For ZSTD, the
+ recommended range is 1 to 22, with the default being 4. Higher
levels
+ provide better compression but slower speed.
+ """
+ compression_enum = Compression.from_str(compression)
+
+ if compression_enum in {Compression.GZIP, Compression.BROTLI,
Compression.ZSTD}:
+ if compression_level is None:
+ compression_level = compression_enum.get_default_level()
Review Comment:
This passes the None handling to Rust.
No tests broken, so this is a good ergonomic suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
