alamb opened a new pull request, #14049: URL: https://github.com/apache/datafusion/pull/14049
Still a WIP ## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/13748 ## Rationale for this change The continued re-normalization of equivalence classes, especially when the number of expressions and number of constants in the sort order is substantial, is very expensive as described on https://github.com/apache/datafusion/issues/13748#issuecomment-2542462344 A substantial amount of the planning time for these queries is continually recomputing a normalized version of OrderingEquivalenceClass. ## What changes are included in this PR? Always keep `OrderingEquivalenceClass` normalized (deprecate OrderingEquivalenceClass::normalized_oeq_class) <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? By CI. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
