kevinjqliu commented on code in PR #13937:
URL: https://github.com/apache/datafusion/pull/13937#discussion_r1906007056
##########
datafusion/ffi/src/lib.rs:
##########
@@ -26,5 +26,14 @@ pub mod session_config;
pub mod table_provider;
pub mod table_source;
+/// Returns the major version of the FFI implementation. If the API evolves,
+/// we use the major version to identify compatibility over the unsafe
+/// boundary.
+pub extern "C" fn version() -> u64 {
+ let version_str = env!("CARGO_PKG_VERSION");
+ let version = semver::Version::parse(version_str).expect("Invalid version
string");
+ version.major
+}
Review Comment:
i dont see this used anywhere in this PR to guard against unsafe boundary;
please ignore if the PR is still WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
