alamb commented on code in PR #14037:
URL: https://github.com/apache/datafusion/pull/14037#discussion_r1905776819
##########
datafusion/physical-expr/src/equivalence/ordering.rs:
##########
@@ -39,7 +39,7 @@ use arrow_schema::SortOptions;
/// ordering. In this case, we say that these orderings are equivalent.
#[derive(Debug, Clone, Eq, PartialEq, Hash, Default)]
pub struct OrderingEquivalenceClass {
- pub orderings: Vec<LexOrdering>,
+ orderings: Vec<LexOrdering>,
Review Comment:
This is the key change -- making this field non-pub -- the rest of the PR is
derived from that and added comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
