alamb commented on issue #14029:
URL: https://github.com/apache/datafusion/issues/14029#issuecomment-2575052672

   > But that would still leave the logical plan invariant extensions for 
consideration.
   
   I would recommend adding a method to: 
https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.UserDefinedLogicalNode.html
   
   Perhaps even the same API:
   
   ```rust
   pub trait UserDefinedLogicalNode { 
   ...
       fn check_invariants(&self, invariant_level: InvariantLevel) -> 
Result<()> 
         Ok(())
       }
   ...
   ```
   
   🤔 
   
   Then you could extend `LogicalPlan::check_invariants` to call that method 
for any `LogicalPlan::UserDefined`
   
   
https://github.com/apache/datafusion/blob/4e877a08d224d992a8cbcc9a14f59468e312b13f/datafusion/expr/src/logical_plan/plan.rs#L1134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to