berkaysynnada commented on PR #14013: URL: https://github.com/apache/datafusion/pull/14013#issuecomment-2574563182
Thanks for addressing this long-standing issue. It remains important and helps us identify bugs earlier. This first step looks good to me. However, the title mentions plan execution for unbounded sources, but the part you added starts with: ```rust if !$SOURCE_UNBOUNDED { ``` It seems the issue addresses three rules and both bounded and unbounded sources. This PR appears to cover only one rule and bounded sources. Do you also plan to add support for unbounded sources? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org