korowa commented on code in PR #13995:
URL: https://github.com/apache/datafusion/pull/13995#discussion_r1904059022
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -522,7 +527,7 @@ impl GroupedHashAggregateStream {
let spill_state = SpillState {
spills: vec![],
spill_expr,
- spill_schema: Arc::clone(&agg_schema),
+ spill_schema: partial_agg_schema,
Review Comment:
Yes, this line seems to be redundant now -- I'd expect all aggregation modes
to have the same spill schema (which is set by this PR), so it shouldn't depend
on stream input anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
