alamb commented on code in PR #14019:
URL: https://github.com/apache/datafusion/pull/14019#discussion_r1904025843
##########
Cargo.toml:
##########
@@ -150,7 +150,7 @@ serde_json = "1"
sqlparser = { version = "0.53.0", features = ["visitor"] }
tempfile = "3"
tokio = { version = "1.36", features = ["macros", "rt", "sync"] }
-url = "2.2"
+url = "2.5.4"
Review Comment:
Thanks @vadimpiven ❤️
FWIW the "2.2" in here previously means that DataFusion would work with any
semver compatible version of url 2.2 and newer
So for example my local checkout already uses 2.5.4
```
name = "url"
version = "2.5.4"
source = "registry+https://github.com/rust-lang/crates.io-index";
checksum = "32f8b686cadd1473f4bd0117a5d28d36b1ade384ea9b5069a1c40aefed7fda60"
dependencies = [
"form_urlencoded",
"idna",
"percent-encoding",
"serde",
]
```
So this change now says Datafusion must use a version of url 2.5.4 or newer,
which seems reasonable to me (given that CI tests runs with the latest version
of dependencies )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
