alamb commented on PR #13984: URL: https://github.com/apache/datafusion/pull/13984#issuecomment-2571429125
> There are no explicit unit tests, but the sisters methods don't have such tests either. These methods are tested indirectly via optimization rules. We can consider whether to add such tests for all such methods in a future PR. I don't think this particular function is invoked by any OptimizerRules yet (maybe it should be) -- since it isn't part of a trait or anything, the rules would have to explicitly check for `MergeJoinExec` as they currently do for `HashJoinExec`: https://github.com/apache/datafusion/blob/b8b0c5584f9f3a3aeca730ef1ac23dafc3e76dde/datafusion/core/src/physical_optimizer/join_selection.rs#L308 That being said, maybe we should make this a method on the `ExecutionPlan` trait to make it more general 🤔 (BTW I don't think any changes / tests are needed for this PR, I am just point this out) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
