alamb commented on code in PR #14007: URL: https://github.com/apache/datafusion/pull/14007#discussion_r1903110630
########## datafusion/sqllogictest/test_files/between.slt: ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Would it be possible to move this file into this https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files/expr directory? We can do it as a follow on PR too ########## datafusion/optimizer/src/analyzer/type_coercion.rs: ########## @@ -426,7 +426,7 @@ impl TreeNodeRewriter for TypeCoercionRewriter<'_> { )) })?; let high_type = high.get_type(self.schema)?; - let high_coerced_type = comparison_coercion(&expr_type, &low_type) + let high_coerced_type = comparison_coercion(&expr_type, &high_type) Review Comment: 🤦 -- nice fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
