alamb commented on code in PR #13988: URL: https://github.com/apache/datafusion/pull/13988#discussion_r1901167134
########## .github/workflows/extended.yml: ########## @@ -23,13 +23,14 @@ concurrency: # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges # -# this job is intended to only run on merge to main branch +# this job is intended to only run only on the main branch as it is time consuming +# and very rarely fails. However, it is important coverage to ensure correctness +# in the (very rare) event of a hash failure. on: - pull_request: + # Run on all commits to main + push: Review Comment: This is the mechanism we use on arrow-rs: https://github.com/apache/arrow-rs/blob/4a0bdde24f48d0fc1222d936493f798d9ea4789d/.github/workflows/arrow.yml#L25-L29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
